Deprecate any uses of class_name with Class objects in put_or_update #18831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 5.1 dropped support for query values of type Class, and we should have fixed most of them with ManageIQ#18827 and ManageIQ#18829, but since detecting callers to put_or_update that do this could be difficult, we can still support this by "fixing" it so rails 5.1 doesn't raise an exception, and give us time to fix the caller.
|
Checked commit jrafanie@af5b7fa with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.1 dropped support for query values of type Class, and we should
have fixed most of them with #18827 and #18829, but since detecting
callers to put_or_update that do this could be difficult, we can still
support this by "fixing" it so rails 5.1 doesn't raise an exception,
and give us time to fix the caller.