MiqReport.get_col_info - fix NoMethodError parse_field_or_tag #18850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comes from #18784, the method exists, but not on MiqReport, only MiqExpression and adding specs for MiqReport.get_col_info - this is being used by the UI, should have tests to catch failures
|
Checked commit https://github.com/himdel/manageiq/commit/28a473ab694c6d12762c1af8c948a0703810f7cf with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
lpichler
approved these changes
Jun 11, 2019
|
👍 |
|
@himdel good find |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comes from #18784, the method exists, but not on MiqReport, only MiqExpression
and adding specs for MiqReport.get_col_info - this is being used by the UI, should have tests to catch failures
Cc @lpichler @kbrock
@miq-bot add_label bug,