Don't create retirement tasks for things that are already retired #18895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
d-m-u
force-pushed
the
adding_already_retired_check_to_service_retire_task_create
branch
from
c2309eb
to
2a6b8f3
Compare
|
Hi @d-m-u , here's the BZ for this issue: https://bugzilla.redhat.com/show_bug.cgi?id=1720338 |
tinaafitz
approved these changes
Jun 19, 2019
|
@mkanoor Please review. |
|
Thanks @d-m-u for making the changes I requested. |
mkanoor
approved these changes
Jun 19, 2019
|
@bdunne any chance I could con you into merging this please? |
d-m-u
changed the title
bdunne
reviewed
Jun 19, 2019
d-m-u
force-pushed
the
adding_already_retired_check_to_service_retire_task_create
branch
from
2a6b8f3
to
c6822d3
Compare
|
Checked commit d-m-u@c6822d3 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Jun 19, 2019
|
@miq-bot add_label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Jul 22, 2019
…service_retire_task_create Don't create retirement tasks for things that are already retired (cherry picked from commit 6bbf5f4) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1728889
|
Hammer backport details: |
d-m-u
deleted the
adding_already_retired_check_to_service_retire_task_create
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't create tasks for already retired VMs.
bz is https://bugzilla.redhat.com/show_bug.cgi?id=1720338
This is ugly but it'll work for now. The refactor ideally involves using the general status check that Lucy's working on, but until that's baked in and finished and well-tested, we have to do something kinda hacky like this. This check doesn't belong inside the retireable? mixin check because that was intended as a class check for, can this class of thing actually be retired? So since this is an instance method check, it has to be here for now.