-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tool to purge archived storages #18902
Merged
gtanzillo
merged 2 commits into
ManageIQ:master
from
agrare:bz_1721612_purge_archived_datastores
Jun 20, 2019
Merged
Add a tool to purge archived storages #18902
gtanzillo
merged 2 commits into
ManageIQ:master
from
agrare:bz_1721612_purge_archived_datastores
Jun 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storages that aren't connected to any hosts aren't automatically deleted and thus a tool is needed to clean them up. This looks for storages which aren't represented in the host_storages table which means they aren't a part of any EMS and can be removed. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1721612
agrare
force-pushed
the
bz_1721612_purge_archived_datastores
branch
from
June 20, 2019 19:29
aa4cf9d
to
f373528
Compare
agrare
force-pushed
the
bz_1721612_purge_archived_datastores
branch
from
June 20, 2019 19:41
9ac034b
to
8e440be
Compare
Checked commits agrare/manageiq@f373528~...8e440be with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 tools/purge_archived_storages.rb
|
gtanzillo
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@agrare "trollop" in hammer branch, FYI. |
@simaishi okay I'll make a PR for hammer |
agrare
pushed a commit
to agrare/manageiq
that referenced
this pull request
Jun 25, 2019
…ed_datastores Add a tool to purge archived storages (cherry picked from commit fb347be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storages that aren't connected to any hosts aren't automatically deleted
and thus a tool is needed to clean them up.
This looks for storages which aren't represented in the host_storages
table which means they aren't a part of any EMS and can be removed.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1721612