[V2V] Don't use the ssh agent when verifying credentials #18920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When verifying credentials for V2V we should not attempt to use the ssh-agent because, in practice, it isn't running on the hosts we connect to.
At the moment the net-ssh library sets the
:use_agent
option to true by default: https://www.rubydoc.info/github/net-ssh/net-ssh/Net/SSH. While this does not prevent the verification from working, it does generate some potentially misleading log information:net.ssh.authentication.agent[a90031c]: Q-task_id([job_dispatcher]) could not connect to ssh-agent: Agent not configured
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1724487