Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Don't use the ssh agent when verifying credentials #18920

Merged
merged 1 commit into from
Jun 28, 2019
Merged

[V2V] Don't use the ssh agent when verifying credentials #18920

merged 1 commit into from
Jun 28, 2019

Conversation

djberg96
Copy link
Contributor

When verifying credentials for V2V we should not attempt to use the ssh-agent because, in practice, it isn't running on the hosts we connect to.

At the moment the net-ssh library sets the :use_agent option to true by default: https://www.rubydoc.info/github/net-ssh/net-ssh/Net/SSH. While this does not prevent the verification from working, it does generate some potentially misleading log information:

net.ssh.authentication.agent[a90031c]: Q-task_id([job_dispatcher]) could not connect to ssh-agent: Agent not configured

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1724487

@djberg96
Copy link
Contributor Author

@miq-bot add_labels transformation, changelog/yes, hammer/no

@djberg96
Copy link
Contributor Author

@miq-bot add_reviewer @agrare

@miq-bot miq-bot requested a review from agrare June 28, 2019 17:05
@agrare agrare self-assigned this Jun 28, 2019
@agrare agrare merged commit 049727a into ManageIQ:master Jun 28, 2019
@agrare agrare added this to the Sprint 115 Ending Jul 8, 2019 milestone Jun 28, 2019
@ghost
Copy link

ghost commented Jul 1, 2019

@miq-bot remove-label hammer/no
@miq-bot add-label hammer/yes

@djberg96 @agrare I'm changing the labels to get it backported in Hammer. The change is pretty small, so the risk is minimal.

@simaishi
Copy link
Contributor

simaishi commented Jul 1, 2019

Hammer backport details:

$ git log -1
commit f3fd05137e83b7a4c80f2d8b1850060b8d990001
Author: Adam Grare <agrare@redhat.com>
Date:   Fri Jun 28 14:46:57 2019 -0400

    Merge pull request #18920 from djberg96/conversion_host_use_agent
    
    [V2V] Don't use the ssh agent when verifying credentials
    
    (cherry picked from commit 049727a5f6369a624dc8f1ebd115effcd927ef76)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1725960

simaishi pushed a commit that referenced this pull request Jul 2, 2019
[V2V] Don't use the ssh agent when verifying credentials

(cherry picked from commit 049727a)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1725960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants