Pass credentials to ansible runner from services

[carbonin]

After this patch I was able to execute a playbook targeting two appliances using a machine credential which used the default username and password for ssh.

Builds on #18968

cc @NickLaMuro @Fryguy

@tinaafitz @bzwei @gmcculloug please review

[NickLaMuro]

Just adding this here as an easy way to compare this to #18968:

https://github.com/carbonin/manageiq/compare/add_credentials_to_runner..pass_credentials_from_services

[NickLaMuro]

This looks good, but obviously the specs are failing. But hey, I fixed them for you!

carbonin#5

Sorta...

Unsure about the first commit, so you might want @bzwei 's opinion on that change if the behavior is correct with your changes or the specs caught a regression being added (I am having a hard time determining that myself).

The rest of the changes are pretty simple, and just need to be implemented here (either with how I did it or otherwise).

[carbonin]

@tinaafitz the last commit here is the spec change we were talking about.

cc @lfu this should allow you to run playbooks against hosts other than localhost

[NickLaMuro]

Looks like this covers all the spec failures I saw. Was testing this on Friday and it seemed to be working as expected.

Good to go from my end.

[tinaafitz]

@carbonin The spec changes look good.

[miq-bot]

Checked commits carbonin/manageiq@a4f2bec~...f3c7231 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
8 files checked, 0 offenses detected
Everything looks fine. 🏆

[miq-bot]

Some comments on commits carbonin/manageiq@a4f2bec~...f3c7231

lib/ansible/runner/credential/machine_credential.rb

• ⚠️ - 17 - Detected pp. Remove all debugging statements.
• ⚠️ - 18 - Detected pp. Remove all debugging statements.

spec/lib/ansible/runner/credential/machine_credential_spec.rb

• ⚠️ - 101 - Detected pp. Remove all debugging statements.
• ⚠️ - 82 - Detected pp. Remove all debugging statements.
• ⚠️ - 83 - Detected pp. Remove all debugging statements.