Pass credentials from ansible playbook automate methods to runner #18983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @NickLaMuro @Fryguy
This bit of code to translate the credentials is now in 4 places 😭 if any of you want to help me work out a way to DRY that up I'd be grateful. That can also come in a follow-up too ...
Here's all the places for the record:
manageiq/app/models/manageiq/providers/embedded_ansible/automation_manager/playbook.rb
Lines 49 to 52 in 55ebb66
manageiq/app/models/service_ansible_playbook.rb
Lines 98 to 104 in 55ebb66
manageiq/app/models/service_template_ansible_playbook.rb
Lines 108 to 111 in 55ebb66
@tinaafitz @lfu please review