Adding tenant stuff to service template copy

[d-m-u]

Service Template copy should include tenant info.

Commit one adds the tenant info per ManageIQ/manageiq-ui-classic#5667 (comment).
Commit two fixes https://github.com/ManageIQ/manageiq/pull/18973/files#r303953846.

@miq-bot assign @tinaafitz
@miq-bot add_reviewer @bdunne

[h-kataria]

@d-m-u i am getting error when trying to copy a catalog item with Additional tenant info

[----] I, [2019-07-17T09:54:49.406810 #10268:447f30c]  INFO -- : Started POST "/catalog/save_copy_catalog" for ::1 at 2019-07-17 09:54:49 -0400
[----] I, [2019-07-17T09:54:49.439889 #10268:447f30c]  INFO -- : Processing by CatalogController#save_copy_catalog as */*
[----] I, [2019-07-17T09:54:49.440064 #10268:447f30c]  INFO -- :   Parameters: {"id"=>"110", "name"=>"Copy of Copy of 13", "catalog"=>{"id"=>"110", "name"=>"Copy of Copy of 13"}}
[----] F, [2019-07-17T09:54:49.475871 #10268:447f30c] FATAL -- : Error caught: [TypeError] no implicit conversion of nil into String
/home/hkataria/dev/manageiq/app/models/service_template/copy.rb:27:in `+'
/home/hkataria/dev/manageiq/app/models/service_template/copy.rb:27:in `block in additional_tenant_copy'
/home/hkataria/.rvm/gems/ruby-2.4.4/gems/activerecord-5.1.7/lib/active_record/relation/delegation.rb:39:in `each'
/home/hkataria/.rvm/gems/ruby-2.4.4/gems/activerecord-5.1.7/lib/active_record/relation/delegation.rb:39:in `each'
/home/hkataria/dev/manageiq/app/models/service_template/copy.rb:25:in `additional_tenant_copy'
/home/hkataria/dev/manageiq/app/models/service_template/copy.rb:11:in `block (2 levels) in template_copy'
/home/hkataria/dev/manageiq/app/models/service_template/copy.rb:7:in `tap'
/home/hkataria/dev/manageiq/app/models/service_template/copy.rb:7:in `block in template_copy'

[h-kataria]

@d-m-u after i made a copy of an item that had additional tenants selected, it seems like it changed names of tenants in my db and prefixed them with "copy of xx" see screenshot

[d-m-u]

Yeah, I saw! I'm looking at it, give me a minute, please.

[h-kataria]

tested, work fine now 👍

[miq-bot]

Checked commits d-m-u/manageiq@c64720b~...d025294 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

[tinaafitz]

Looks good.

[tinaafitz]

@bdunne Please review.