Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set vm name on reconnect #19031

Merged
merged 1 commit into from
Jul 23, 2019
Merged

set vm name on reconnect #19031

merged 1 commit into from
Jul 23, 2019

Conversation

AlexanderZagaynov
Copy link
Contributor

@AlexanderZagaynov AlexanderZagaynov commented Jul 23, 2019 •
edited by simaishi
Loading

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1724312
it was not the root issue for that BZ, but it should be fixed anyway

Also fixes https://bugzilla.redhat.com/show_bug.cgi?id=1730819

@AlexanderZagaynov
Copy link
Contributor Author

@agrare @juliancheal please review

@juliancheal
Copy link
Member

👍 LTGM

@agrare agrare self-assigned this Jul 23, 2019
@juliancheal
Copy link
Member

Related to ManageIQ/manageiq-providers-azure#338

@miq-bot
Copy link
Member

miq-bot commented Jul 23, 2019

Checked commit AlexanderZagaynov@3fd6288 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare merged commit 3fd6288 into ManageIQ:master Jul 23, 2019
agrare added a commit that referenced this pull request Jul 23, 2019
@agrare
Merge pull request #19031 from AlexanderZagaynov/BZ-1724312_unable_to…
d538216 
…_receive_events

set vm name on reconnect
@agrare agrare added this to the Sprint 116 Ending Jul 22, 2019 milestone Jul 23, 2019
@simaishi
Copy link
Contributor

hammer/yes ?

@agrare
Copy link
Member

agrare commented Jul 25, 2019

Yes

simaishi pushed a commit that referenced this pull request Jul 25, 2019
@agrare @simaishi
Merge pull request #19031 from AlexanderZagaynov/BZ-1724312_unable_to…
e725e22 
…_receive_events

set vm name on reconnect

(cherry picked from commit d538216)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1733383
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit e725e22e2a8b06fee660178b32291d6f39671a0b
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Jul 23 11:06:41 2019 -0400

    Merge pull request #19031 from AlexanderZagaynov/BZ-1724312_unable_to_receive_events
    
    set vm name on reconnect
    
    (cherry picked from commit d538216bee7cb573342a28cda903d64ec232ed19)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1733383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
bug changelog/yes core/events hammer/backported providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexanderZagaynov @juliancheal @miq-bot @simaishi @agrare