Fix: make chargeback generation for service to be region aware and do not generate for retired service #19101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… servcie in the same region
yrudman
force-pushed
the
make-chargeback-for-service-region-aware
branch
from
3071645
to
b510356
Compare
yrudman
changed the title
|
Checked commits yrudman/manageiq@4622cf5~...b510356 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Aug 8, 2019
|
After discussion, this is only accessible from the API and the only consumer (SSUI) knows to go to each region to get the report. |
simaishi
pushed a commit
that referenced
this pull request
Aug 8, 2019
…gion-aware Fix: make chargeback generation for service to be region aware and do not generate for retired service (cherry picked from commit 3bcda04) https://bugzilla.redhat.com/show_bug.cgi?id=1736749
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Oct 21, 2019
…gion-aware Fix: make chargeback generation for service to be region aware and do not generate for retired service (cherry picked from commit 3bcda04) https://bugzilla.redhat.com/show_bug.cgi?id=1763862
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: chargeback generation was triggered for all services, regardless service been retired or belongs to different region.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1736749
@miq-bot add-label bug, core, changelog/yes, hammer/yes, ivanchuk/yes
\cc @gtanzillo