Add Auth KeyPair Ownership feature #19124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label hammer/yes |
This was referenced Aug 9, 2019
h-kataria
reviewed
Aug 12, 2019
db/fixtures/miq_product_features.yml
Outdated
| @@ -864,6 +864,10 @@ | |||
| :description: Edit Tags of Key Pairs | |||
| :feature_type: control | |||
| :identifier: auth_key_pair_cloud_tag | |||
| - :name: Set Ownership | |||
| :description: Set Ownership of Instances | |||
There was a problem hiding this comment.
should be Set Ownership of Key Pairs
PanSpagetka
force-pushed
the
add-keypair-ownership-feature
branch
from
d2fe83e
to
b565ac8
Compare
PanSpagetka
force-pushed
the
add-keypair-ownership-feature
branch
from
b565ac8
to
1b82b59
Compare
|
Checked commit PanSpagetka@1b82b59 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
h-kataria
approved these changes
Aug 13, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 15, 2019
Add Auth KeyPair Ownership feature (cherry picked from commit 2501976) https://bugzilla.redhat.com/show_bug.cgi?id=1589766 https://bugzilla.redhat.com/show_bug.cgi?id=1730066
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Aug 15, 2019
Add Auth KeyPair Ownership feature (cherry picked from commit 2501976) https://bugzilla.redhat.com/show_bug.cgi?id=1741634 https://bugzilla.redhat.com/show_bug.cgi?id=1741635
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is needed for adding Set Ownership screen. It should be backported to Hammer.
Links [Optional]
ManageIQ/manageiq-ui-classic#5967
ManageIQ/manageiq-ui-classic#5973
https://bugzilla.redhat.com/show_bug.cgi?id=1589766
https://bugzilla.redhat.com/show_bug.cgi?id=1730066