Fixed MiqSearch.seed when search name was changed and corrected typo miq_search.yml #19151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
fix-seed-miq-search
branch
from
00869eb
to
d18e09f
Compare
There is no easy way to correct typo in the name of search Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740309
yrudman
force-pushed
the
fix-seed-miq-search
branch
from
d18e09f
to
9e04470
Compare
yrudman
force-pushed
the
fix-seed-miq-search
branch
from
9e04470
to
fe6fadd
Compare
|
Checked commits yrudman/manageiq@ed28613~...fe6fadd with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
yrudman
changed the title
yrudman
changed the title
yrudman
changed the title
|
@miq-bot add-label blocker |
simaishi
pushed a commit
that referenced
this pull request
Nov 1, 2019
Fixed MiqSearch.seed when search name was changed and corrected typo miq_search.yml (cherry picked from commit 0e86685) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767777
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: If name of search changed in
db/fixtures/miq_search.ymlthan second record created in addition to the old oneFIX: change
MiqSearch.seedto destroy records representing default searches which we are not supplying anymoreThis PR also fixed typo in
db/fixtures/miq_search.yml, which was introduced in #17815Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740309
@miq-bot add-label bug, core, changelog/yes, hammer/yes, ivanchuk/yes