Fix the custom button set set_data hash links to the original buttons on copy #19169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
force-pushed
the
fixing_custom_button_set_copy_children
branch
from
48f4ac5
to
6d1b45a
Compare
|
Checked commit d-m-u@6d1b45a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
reviewed
Aug 20, 2019
bdunne
modified the milestones:
Sprint 118 Ending Aug 19, 2019,
Sprint 119 Ending Sep 2, 2019
|
I'd like to backport to h along with #18368 for https://bugzilla.redhat.com/show_bug.cgi?id=1737449 |
|
@miq-bot add_label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Aug 21, 2019
…ildren Fix the custom button set set_data hash links to the original buttons on copy (cherry picked from commit 68f281d) https://bugzilla.redhat.com/show_bug.cgi?id=1740556 https://bugzilla.redhat.com/show_bug.cgi?id=1737449
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Sep 5, 2019
…ildren Fix the custom button set set_data hash links to the original buttons on copy (cherry picked from commit 68f281d) https://bugzilla.redhat.com/show_bug.cgi?id=1745198
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740556
Also needed for https://bugzilla.redhat.com/show_bug.cgi?id=1737449
The button set copy needs to reset and then save the new button order.
@miq-bot add_label bug, ivanchuk/yes
@miq-bot assign @bdunne