Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EmbeddedAnsible] Force embedded_ansible role for workflow #19187

Commits on Aug 22, 2019

  1. [EmbeddedAnsible] Force embedded_ansible role for workflow

    The `queue_signal` method in `AnsibleRunnerWorkflow` forces the
    "ems_operations" role when it schedules a queue item, but this class
    (which inherits from `AnsibleRunnerWorkflow`) is getting assigned this
    job from a wrapper job that requires the `embedded_ansible` role.  In
    addition, the previous job queue an job that is locked to the existing
    server guid, so it is possible for that server to take the first job,
    but not the second when it doesn't have both an "embedded_ansible" and
    "ems_operations" role.
    
    When a server exists that only has the "embedded_ansible" role, it is
    possible to get into a state where a playbook can be scheduled, but then
    is never ran because no server matches.  This fix simply always uses the
    "embedded_ansible" role for everything, but tries to only modify the
    lower level classes to achieve that.
    
    Fixes:  https://bugzilla.redhat.com/show_bug.cgi?id=1742839
    NickLaMuro committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    78f9fe7 View commit details
    Browse the repository at this point in the history