Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Remove .py extension from calls to virt-v2v-wrapper #19194

Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2019

Over time, virt-v2v-wrapper has evolved and will continue to evolve. To prepare for that, it has been renamed from virt-v2v-wrapper.py to virt-v2v-wrapper. The name with .py extension still exist for backward compatibility, but it might be removed later.

This PR changes calls to virt-v2v-wrapper to remove the .py extension.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1744949

@ghost ghost changed the title Remove .py extension from calls to virt-v2v-wrapper [V2V] Remove .py extension from calls to virt-v2v-wrapper Aug 23, 2019
@ghost
Copy link
Author

ghost commented Aug 23, 2019

@miq-bot add-label transformation, enhancement, ivanchuk/yes
@miq-bot add-reviewer @djberg96
@miq-bot add-reviewer @agrare

@miq-bot
Copy link
Member

miq-bot commented Aug 23, 2019

Checked commit fabiendupont@f1ac37c with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare self-assigned this Aug 23, 2019
agrare added a commit that referenced this pull request Aug 23, 2019
…_of_wrapper

[V2V] Remove .py extension from calls to virt-v2v-wrapper
@agrare agrare merged commit f1ac37c into ManageIQ:master Aug 23, 2019
@agrare agrare added this to the Sprint 119 Ending Sep 2, 2019 milestone Aug 23, 2019
@ghost ghost deleted the v2v_remove_py_extension_of_wrapper branch August 23, 2019 12:24
simaishi pushed a commit that referenced this pull request Oct 31, 2019
…_of_wrapper

[V2V] Remove .py extension from calls to virt-v2v-wrapper

(cherry picked from commit f2ea41c)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767548
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 050e76e262e76f3f317c4fbaff98c3b123a7896e
Author: Adam Grare <agrare@redhat.com>
Date:   Fri Aug 23 07:43:44 2019 -0400

    Merge pull request #19194 from fdupont-redhat/v2v_remove_py_extension_of_wrapper
    
    [V2V] Remove .py extension from calls to virt-v2v-wrapper
    
    (cherry picked from commit f2ea41c8c39ba5081ea58b3e282f302f443dce6a)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants