Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add order option to SupportsFeatureMixin module #19203

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Add order option to SupportsFeatureMixin module #19203

merged 2 commits into from
Aug 26, 2019

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented Aug 26, 2019

This is a followup (or prequel?) to #19186 that would allow the ability to set whether or not a given service is actually orderable.

At the moment there's only ServiceTemplate.validate_order which returns a simple boolean. This allows for more flexibility for subclasses/providers that can hook into it and provide custom messages if/when it's not supported.

Update: This also explicitly includes the SupportsFeatureMixin into the ServiceTemplate class, and adds a default supports :order to it.

@djberg96
Copy link
Contributor Author

@miq-bot add_reviewer @agrare

@miq-bot miq-bot requested a review from agrare August 26, 2019 17:07
@agrare agrare self-assigned this Aug 26, 2019
@agrare
Copy link
Member

agrare commented Aug 26, 2019

@djberg96 can you add the first supports :order to ServiceTemplate in this commit so it doesn't look like there's an unused feature?

@djberg96
Copy link
Contributor Author

@agrare Done.

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice, looks good @djberg96

@miq-bot
Copy link
Member

miq-bot commented Aug 26, 2019

Checked commits https://github.com/djberg96/manageiq/compare/a73a816e5e94ca7b01cca40af3c1c72946f80475~...69684c2978dd8d6b231facdf0b10db8837203016 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

agrare added a commit that referenced this pull request Aug 26, 2019
Add order option to SupportsFeatureMixin module
@agrare agrare merged commit 69684c2 into ManageIQ:master Aug 26, 2019
@agrare agrare added this to the Sprint 119 Ending Sep 2, 2019 milestone Aug 26, 2019
@simaishi
Copy link
Contributor

@djberg96 can this be ivanchuk/yes?

@simaishi
Copy link
Contributor

simaishi commented Nov 4, 2019

@djberg96 ^ ping

@djberg96
Copy link
Contributor Author

djberg96 commented Nov 4, 2019

@simaishi Pretty sure, yes. @agrare Do you have any objection?

@agrare
Copy link
Member

agrare commented Nov 4, 2019

Fine with me

simaishi pushed a commit that referenced this pull request Nov 4, 2019
Add order option to SupportsFeatureMixin module

(cherry picked from commit baeb7ba)

https://bugzilla.redhat.com/show_bug.cgi?id=1768520
@simaishi
Copy link
Contributor

simaishi commented Nov 4, 2019

Ivanchuk backport details:

$ git log -1
commit ac4757e1ad3235aa09516f2c03464c6c0b9f6edd
Author: Adam Grare <agrare@redhat.com>
Date:   Mon Aug 26 15:55:19 2019 -0400

    Merge pull request #19203 from djberg96/supports_feature_order
    
    Add order option to SupportsFeatureMixin module
    
    (cherry picked from commit baeb7ba143c811e402f8507c386fc669efabf527)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1768520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants