Set service's lifecycle_state based on miq_request_task's state. #19205
Conversation
|
@mkanoor Please review. |
| end | ||
|
|
||
| private | ||
|
|
||
| def top_task_for_service? | ||
| source_type == "ServiceTemplate" |
There was a problem hiding this comment.
@lfu Just for information what is the source_type for other other child services wouldn't they be ServiceTemplate too.
There was a problem hiding this comment.
As stated in the description, the child service could have MiqRequest or ServiceTempalte for source_type.
There was a problem hiding this comment.
To be clear the reference to MiqRequest is the MiqProvisionRequestTemplate sub-class.
I found the name confusing as I kept thinking it was trying to reference the top task (the one for the service bundle), but it is really just trying to identify if the source of the task is a ServiceTemplate.
Maybe a better name would be: service_template_source?
lfu
force-pushed
the
bundle_lifecycle_1743550
branch
from
b1cd8b2
to
b089207
Compare
|
Checked commit lfu@b089207 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Set service's lifecycle_state based on miq_request_task's state. (cherry picked from commit 5aa663b) https://bugzilla.redhat.com/show_bug.cgi?id=1743550
|
Ivanchuk backport details: |
With bundle service, all the top and sub services are connected to the same request.
A sub service may have two
ServiceTemplateProvisionTask. One hasServiceTemplateas the source while the other hasMiqRequest.https://bugzilla.redhat.com/show_bug.cgi?id=1743550
@miq-bot assign @tinaafitz
@miq-bot add_label bug, services, ivanchuk/yes, changelog/yes, blocker