Reload stale source_tenant after destroying self (rails 5.2) #19367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rails 5.2, this stale source_tenant has a "source" CloudManager
during this "after_destroy" callback. This causes the
source_tenant.destroy to fail, thinking the "source" CloudManager still
exists.
Fixes:
5) ManageIQ::Providers::CloudManager OpenStack CloudTenant Mapping #sync_cloud_tenants_with_tenants creation of tenant tree cleans up created tenant tree when the ems is destroyed
Failure/Error: expect(Tenant.count).to eq(1)
expected: 1
got: 2
(compared using ==)
# ./spec/models/manageiq/providers/cloud_manager_spec.rb:205:in `block (5 levels) in <top (required)>'
|
Checked commit jrafanie@c07a434 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
approved these changes
Oct 4, 2019
| @@ -159,6 +159,8 @@ def self.display_name(number = 1) | |||
|
|
|||
| def destroy_mapped_tenants | |||
| if source_tenant | |||
| # We just destroyed ourself, reload the source_tenant association | |||
| source_tenant.reload | |||
| source_tenant.all_subtenants.destroy_all | |||
| source_tenant.all_subprojects.destroy_all | |||
There was a problem hiding this comment.
darn - feels like this should all be destroyed in tenant itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rails 5.2, this stale source_tenant has a "source" CloudManager
during this "after_destroy" callback. This causes the
source_tenant.destroy to fail, thinking the "source" CloudManager still
exists.
Fixes: