Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Remove handover from shutdown_vm transition #19371

Conversation

ghost
Copy link

@ghost ghost commented Oct 7, 2019

When implementing the InfraConversionJob state machine, we forgot to remove the handover_to_automate call in shutdown_vm transition method. This PR removes it.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1759062

@ghost
Copy link
Author

ghost commented Oct 7, 2019

@miq-bot add-label transformation, bug, ivanchuk/yes
@miq-bot add-reviewer @agrare

@miq-bot
Copy link
Member

miq-bot commented Oct 7, 2019

Checked commit fabiendupont@cb7738c with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare self-assigned this Oct 7, 2019
@agrare agrare merged commit 8bf39a9 into ManageIQ:master Oct 7, 2019
@agrare agrare added this to the Sprint 122 Ending Oct 14, 2019 milestone Oct 7, 2019
@ghost ghost deleted the v2v_remove_handover_from_shutdown_vm_transition branch October 7, 2019 13:24
simaishi pushed a commit that referenced this pull request Feb 21, 2020
…m_shutdown_vm_transition

[V2V] Remove handover from shutdown_vm transition

(cherry picked from commit 8bf39a9)

https://bugzilla.redhat.com/show_bug.cgi?id=1789433
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit e2e8a260c28fbc9fae64f2a0e50b2e5a4182461f
Author: Adam Grare <agrare@redhat.com>
Date:   Mon Oct 7 08:52:08 2019 -0400

    Merge pull request #19371 from fdupont-redhat/v2v_remove_handover_from_shutdown_vm_transition

    [V2V] Remove handover from shutdown_vm transition

    (cherry picked from commit 8bf39a9bd18fe10b46968d208f86a66eb26af0d3)

    https://bugzilla.redhat.com/show_bug.cgi?id=1789433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants