Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2V] Fix progress percentage calculation #19375

Merged
merged 3 commits into from
Oct 7, 2019
Merged

[V2V] Fix progress percentage calculation #19375

merged 3 commits into from
Oct 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 7, 2019

This PR aims at fixing the progress reporting:

  • The percentage was incorrect and went beyond 100%
  • The total weights of the states was only 85, instead of 100
  • The current state was not reported, making the migration look stalled

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1759062

@ghost
Copy link
Author

ghost commented Oct 7, 2019

@miq-bot add-label transformation, bug, ivanchuk/yes
@miq-bot add-reviewer @agrare

@miq-bot miq-bot requested a review from agrare October 7, 2019 17:45
@agrare agrare self-assigned this Oct 7, 2019
@miq-bot
Copy link
Member

miq-bot commented Oct 7, 2019

Checked commits fabiendupont/manageiq@25c44ae~...35d4159 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare merged commit 9876943 into ManageIQ:master Oct 7, 2019
@agrare agrare added this to the Sprint 122 Ending Oct 14, 2019 milestone Oct 7, 2019
@ghost ghost deleted the v2v_fix_progress_percent_calculation branch October 9, 2019 08:30
simaishi pushed a commit that referenced this pull request Feb 21, 2020
@agrare @simaishi
Merge pull request #19375 from fdupont-redhat/v2v_fix_progress_percen…
4e7c1cf 
…t_calculation

[V2V] Fix progress percentage calculation

(cherry picked from commit 9876943)

https://bugzilla.redhat.com/show_bug.cgi?id=1789433
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 4e7c1cf398af6fe7422fcbad70cba99767492273
Author: Adam Grare <agrare@redhat.com>
Date:   Mon Oct 7 16:26:11 2019 -0400

    Merge pull request #19375 from fdupont-redhat/v2v_fix_progress_percent_calculation

    [V2V] Fix progress percentage calculation

    (cherry picked from commit 9876943bb8c49777eb4286feb321998311ca3342)

    https://bugzilla.redhat.com/show_bug.cgi?id=1789433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@agrare agrare

Labels
bug ivanchuk/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miq-bot @simaishi @agrare @fabiendupont