Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggable ScanItems #19388

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Pluggable ScanItems #19388

merged 1 commit into from
Oct 14, 2019

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Oct 10, 2019

This PR introduces pluggable scan items in a similar way to dialogs and product features.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1773640

@bdunne Please review

cc @agrare @pemcg @jrafanie

@Fryguy
Copy link
Member Author

Fryguy commented Oct 10, 2019

Technically this improves seeding performance as well, but barely any :)

first seed second seed
before 161.8 ms 111.4 ms
after 104.8 ms 24.0 ms
savings 35.2% 78.5%

end

it "will include files from plugins" do
skip "Until a plugin brings a scan item"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pemcg Just wanted to clue you into this one. When you end up adding your scan item to v2v, please submit a PR to remove this skip line.

For now, I couldn't figure out a way to ensure this works without having a plugin bring a scan item. In the future @bdunne suggested we move our default scan items to manageiq-content, drop the core bringing scan items, then this test will just work.

@miq-bot
Copy link
Member

miq-bot commented Oct 10, 2019

Checked commit Fryguy@118170a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

spec/models/scan_item/seeding_spec.rb

  • ❗ - Line 56, Col 68 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.

@durandom durandom mentioned this pull request Oct 10, 2019
38 tasks
@bdunne bdunne merged commit c0664f7 into ManageIQ:master Oct 14, 2019
@bdunne bdunne added this to the Sprint 122 Ending Oct 14, 2019 milestone Oct 14, 2019
@Fryguy Fryguy deleted the pluggable_scan_items branch October 17, 2019 14:34
simaishi pushed a commit that referenced this pull request Nov 18, 2019
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 75d79eadf0c5a291e926e6db5557d2d6bccaf5e8
Author: Brandon Dunne <bdunne@redhat.com>
Date:   Mon Oct 14 14:15:39 2019 -0400

    Merge pull request #19388 from Fryguy/pluggable_scan_items
    
    Pluggable ScanItems
    
    (cherry picked from commit c0664f72920d8c50019144288e8dff11466bab23)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1773703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants