-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pluggable ScanItems #19388
Pluggable ScanItems #19388
Conversation
0ca8a7c
to
7991b41
Compare
7991b41
to
fd8bc89
Compare
Technically this improves seeding performance as well, but barely any :)
|
fd8bc89
to
118170a
Compare
end | ||
|
||
it "will include files from plugins" do | ||
skip "Until a plugin brings a scan item" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pemcg Just wanted to clue you into this one. When you end up adding your scan item to v2v, please submit a PR to remove this skip line.
For now, I couldn't figure out a way to ensure this works without having a plugin bring a scan item. In the future @bdunne suggested we move our default scan items to manageiq-content, drop the core bringing scan items, then this test will just work.
Checked commit Fryguy@118170a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 spec/models/scan_item/seeding_spec.rb
|
Pluggable ScanItems (cherry picked from commit c0664f7) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1773703
Ivanchuk backport details:
|
This PR introduces pluggable scan items in a similar way to dialogs and product features.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1773640
@bdunne Please review
cc @agrare @pemcg @jrafanie