Generate perfomance reports in specific date range #19393
Conversation
lpichler
force-pushed
the
generate_perfomance_reports_in_specific_date_range
branch
from
9743cdc
to
f74a361
Compare
app/models/miq_report/generator.rb
Outdated
| @@ -245,18 +245,25 @@ def generate_performance_results(options = {}) | |||
| results | |||
| end | |||
|
|
|||
| def performance_report_time_range | |||
| if db_options[:specific_date] | |||
There was a problem hiding this comment.
What do you think about renaming this option to custom_rnge or custom_time_range? I think that would be more descriptive
There was a problem hiding this comment.
@lpichler Sorry, I was referring to the option db_options[:specific_date] when I suggested renaming it. I think performance_report_time_range was fine since it covers both cases.
What do you think about putting the method name back to performance_report_time_range and renaming the option to db_options[:custom_time_range]?
There was a problem hiding this comment.
oh, yes sure, I missed correct line , thanks that you noticed it 👍
now it should be done 👍
lpichler
force-pushed
the
generate_perfomance_reports_in_specific_date_range
branch
from
f74a361
to
d76a8e9
Compare
|
done 👍 |
lpichler
force-pushed
the
generate_perfomance_reports_in_specific_date_range
branch
from
d76a8e9
to
f44553d
Compare
|
Checked commits lpichler/manageiq@743e766~...f44553d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
lpichler
deleted the
generate_perfomance_reports_in_specific_date_range
branch
this BZ require UI part to be set specific date range
Links
@miq-bot assign @gtanzillo
@miq-bot add_label reporting, enhancement