Generate retire requests from the base class name #19398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label retirement |
|
@bdunne could I please ask you to review? |
lfu
reviewed
Oct 15, 2019
d-m-u
force-pushed
the
fixing_retire_request_class_name_constantize
branch
from
256c5cd
to
9a032c4
Compare
|
Checked commit d-m-u@9a032c4 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
lfu
approved these changes
Oct 15, 2019
simaishi
pushed a commit
that referenced
this pull request
Oct 21, 2019
…_constantize Generate retire requests from the base class name (cherry picked from commit b7c9523) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1762428
|
Hammer backport details: |
simaishi
added a commit
that referenced
this pull request
Oct 21, 2019
…ass_name_constantize" This reverts commit 97c8ac3. https://bugzilla.redhat.com/show_bug.cgi?id=1762428
|
Reverted the hammer backport: due to Travis error: |
|
Because it depended on #19064 and the linked content PR ManageIQ/manageiq-content#552, and ManageIQ/manageiq-api#662, all of which aren't backported though they're all marked hammer/yes. I can't do anything here. |
|
You did what you needed to do (mentioning dependencies), so it's all set now 😄 |
simaishi
pushed a commit
that referenced
this pull request
Dec 17, 2019
…_constantize Generate retire requests from the base class name (cherry picked from commit b7c9523) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1784486
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Dec 19, 2019
…_constantize Generate retire requests from the base class name (cherry picked from commit b7c9523) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1762428
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceAnsiblePlaybook.demodulize + "RetireRequest"=> bad cause we try and constantize that n there is no SAPRR; we should be using only the base class name formake_retire_requestAlso, it's passing specs and got BZ opener approval here: https://bugzilla.redhat.com/show_bug.cgi?id=1731559#c6
Depends on #19064
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1731559
@miq-bot add_label bug, hammer/yes, ivanchuk/yes
@miq-bot add_reviewer @tinaafitz
@miq-bot add_reviewer @lfu