Passes result_format when automate workspace is not expected #19407
Conversation
|
So this is when a dynamic dialog fields are being processed (for the dialog player). Both cases are on the same code path (in core) and they require different handling, right? I suggest we try to understand the situations and pass some argument to indicate the difference rather than change it one way or another. I can understand if a quick fix is needed for Invanchuk, though. We probably need some argument that will tell to ignore the workspace to be passed from the UI. Or vice versa -- an argument to be passed not to ignore the workspace. |
|
I don't think https://bugzilla.redhat.com/show_bug.cgi?id=1762339 is the bug for this. They're unrelated, I just happened to run into this while looking at that bz. |
lfu
force-pushed
the
result_format_1762339
branch
from
dc46025
to
bb0aabd
Compare
lfu
changed the title
spec/models/resource_action_spec.rb
Outdated
| @@ -109,13 +109,17 @@ | |||
| end | |||
|
|
|||
| context "#automate_queue_hash" do | |||
| let(:button) { FactoryBot.create(:custom_button, :applies_to_class => "Vm") } | |||
| let(:button) { FactoryBot.create(:custom_button, :applies_to_class => "Vm", :options => {:open_url => true}) } | |||
There was a problem hiding this comment.
, :options => {:open_url => true}
do we need this change?
Dynamic dialog expects a workspace object.
lfu
force-pushed
the
result_format_1762339
branch
from
bb0aabd
to
604f13a
Compare
|
Checked commit lfu@604f13a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This fixes service dialog dynamic fields breaking for me, thanks! :) (ManageIQ/manageiq-automation_engine#354 (comment)) |
Dynamic dialog expects a workspace object from
deliver_to_automate_from_dialog_field.Undo #19270.
@miq-bot assign @tinaafitz
@miq-bot add_label bug, Ivanchuk/yes, changelog/yes
cc @martinpovolny