Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Pin InfraConversionJob to first server where it runs #19416

Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 18, 2019

When running VM migration in a multi-appliances environment, the states of the InfraConversionJob can be execute on different appliances. It makes it difficult to follow the logs and troubleshoot issues. We will use this pinning to collect the log for a specific VM migration.

InfraConversionJob is mainly the workflow runner, but most of the long running operations are executed asynchronously, so we don't expect a high level of load on the appliance the runs the job.

This PR implement the same mechanism as AnsibleRunnerWorkflow [L108].

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1763043

@ghost ghost changed the title Pin InfraConversionJob to first server where it runs [V2V] Pin InfraConversionJob to first server where it runs Oct 18, 2019
@ghost
Copy link
Author

ghost commented Oct 18, 2019

@miq-bot add-label transformation, enhancement, ivanchuk/yes
@miq-bot add-reviewer @Fryguy

@miq-bot
Copy link
Member

miq-bot commented Oct 18, 2019

Checked commits fabiendupont/manageiq@fbb761a~...5fed79d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@djberg96
Copy link
Contributor

👍

@Fryguy Fryguy merged commit 6006ece into ManageIQ:master Oct 18, 2019
@Fryguy Fryguy added this to the Sprint 123 Ending Oct 28, 2019 milestone Oct 18, 2019
@Fryguy Fryguy self-assigned this Oct 18, 2019
@ghost ghost deleted the v2v_pin_infraconversionjob_to_server branch October 18, 2019 13:21
@ghost ghost mentioned this pull request Nov 4, 2019
simaishi pushed a commit that referenced this pull request Nov 4, 2019
…job_to_server

[V2V] Pin InfraConversionJob to first server where it runs

(cherry picked from commit 6006ece)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768532
@simaishi
Copy link
Contributor

simaishi commented Nov 4, 2019

Ivanchuk backport details:

$ git log -1
commit 5bfdeeae991d70928998786ff9467db90756b68e
Author: Jason Frey <jfrey@redhat.com>
Date:   Fri Oct 18 09:20:15 2019 -0400

    Merge pull request #19416 from fdupont-redhat/v2v_pin_infraconversionjob_to_server
    
    [V2V] Pin InfraConversionJob to first server where it runs
    
    (cherry picked from commit 6006ece703c126c971179ac1ebc478a14ebf23b5)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768532

@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2019

Temporarily reverted backport as this causes conflicts reverting other PRs.

commit 792749483760f405297562aafc15ca914a9f0248
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Tue Dec 3 12:42:46 2019 -0500

    Revert "Merge pull request #19416 from fdupont-redhat/v2v_pin_infraconversionjob_to_server"

    This reverts commit 5bfdeeae991d70928998786ff9467db90756b68e.

    https://bugzilla.redhat.com/show_bug.cgi?id=1768532

simaishi pushed a commit that referenced this pull request Feb 21, 2020
…job_to_server

[V2V] Pin InfraConversionJob to first server where it runs

(cherry picked from commit 6006ece)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768532
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 056d6739ca40ea72ba0e49d07500fa1d9605a2dd
Author: Jason Frey <jfrey@redhat.com>
Date:   Fri Oct 18 09:20:15 2019 -0400

    Merge pull request #19416 from fdupont-redhat/v2v_pin_infraconversionjob_to_server

    [V2V] Pin InfraConversionJob to first server where it runs

    (cherry picked from commit 6006ece703c126c971179ac1ebc478a14ebf23b5)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants