Update to config gem 2.0.0 #19418
Merged
Update to config gem 2.0.0 #19418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 1.7.0 introduced merge_nil_values, ironically by me, which we have to disable. This is because we often have leaf configurations with nil values as examples, which overwrite core values, leading to lots of problems. For now we have to disable this behavior. https://github.com/railsconfig/config/pull/196/files See also: https://github.com/ManageIQ/manageiq/pull/16982/files * 2.0.0 changed the Config constant to be defined on Object, not Kernel, so we need to update our configuration to reflect this same change: https://github.com/railsconfig/config/pull/227/files Also, config gem at 1.6.1 was loading dry-validation which was really slow. Now with 2.0.0, it uses dry-schema, which is slightly less slow. It seems to save ~0.3 seconds on rails boot. Config 1.6.1: ``` 04:49:04 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 6.12s user 3.84s system 88% cpu 11.227 total 04:49:17 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.81s user 3.23s system 99% cpu 9.133 total 04:49:28 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.92s user 3.32s system 98% cpu 9.338 total 04:49:38 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 6.09s user 3.55s system 98% cpu 9.793 total ``` Config 2.0.0: ``` 04:43:03 ~/Code/manageiq (master) (2.6.5) - time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.90s user 3.53s system 90% cpu 10.403 total 04:43:16 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.54s user 2.99s system 99% cpu 8.610 total 04:43:25 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.64s user 3.14s system 98% cpu 8.879 total 04:43:35 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.64s user 3.12s system 99% cpu 8.841 total ```
jrafanie
commented
Oct 18, 2019
| @@ -33,7 +33,7 @@ gem "bcrypt", "~> 3.1.10", :require => false | |||
| gem "bundler", ">=1.15", :require => false | |||
| gem "byebug", :require => false | |||
| gem "color", "~>1.8" | |||
| gem "config", "~>1.6.0", :require => false | |||
| gem "config", "~>2.0", :require => false | |||
There was a problem hiding this comment.
I can lock this down to ~>2.0.0 if desired. It's been pretty stable, so 🤷♂
|
Checked commit jrafanie@2711b70 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Fryguy
approved these changes
Oct 20, 2019
|
Please run other repos with this change. |
|
Ok, cross repo is green https://travis-ci.org/jrafanie/manageiq-cross_repo/builds/600748920 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT:
Added cross-repo tests against this branch:
1.7.0 introduced merge_nil_values, ironically by me, which we have to disable.
This is because we often have leaf configurations with nil values as examples,
which overwrite core values, leading to lots of problems. For now we have to
disable this behavior.
2.0.0 changed the Config constant to be defined on Object, not Kernel, so we
need to update our configuration to reflect this same change:
Also, config gem at 1.6.1 was loading dry-validation which was really slow. Now
with 2.0.0, it uses dry-schema, which is slightly less slow. It seems to save
~0.3 seconds on rails boot.
Config 1.6.1:
Config 2.0.0: