Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replicate_server_settings is parsing serverid incorrect #19433

Merged
merged 1 commit into from
Oct 28, 2019
Merged

replicate_server_settings is parsing serverid incorrect #19433

merged 1 commit into from
Oct 28, 2019

Conversation

evertmulder
Copy link
Contributor

When providing a server id to replicate_server_settings.rb it is always parsed as 'true' and not as the supplied value.

Steps for Testing/QA [Optional]

./replicate_server_settings.rb -d -s 7 -p company

Results in:

{:dry_run=>true, :serverid=>true, :path=>"company", :help=>false, :dry_run_given=>true, :serverid_given=>true, :path_given=>true}
Traceback (most recent call last):
        1: from ./replicate_server_settings.rb:19:in `<main>'
/usr/local/lib/ruby/gems/2.5.0/gems/activerecord-5.1.7/lib/active_record/core.rb:189:in `find': Couldn't find MiqServer with 'id'=true (ActiveRecord::RecordNotFound)

@miq-bot
Copy link
Member

miq-bot commented Oct 25, 2019

Checked commit evertmulder@777759e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice find @evertmulder !

@agrare agrare self-assigned this Oct 28, 2019
agrare added a commit that referenced this pull request Oct 28, 2019
replicate_server_settings is parsing serverid incorrect
@agrare agrare merged commit 777759e into ManageIQ:master Oct 28, 2019
@agrare agrare added the tools label Oct 28, 2019
@agrare agrare added this to the Sprint 123 Ending Oct 28, 2019 milestone Oct 28, 2019
@agrare agrare added the bug label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants