Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of gems for AWS SDK usage #19436

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Reduce the number of gems for AWS SDK usage #19436

merged 1 commit into from
Oct 25, 2019

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Oct 25, 2019

This was referenced Oct 25, 2019
Merged
Merged
Fryguy added a commit to Fryguy/manageiq-cross_repo-tests that referenced this pull request Oct 25, 2019
@Fryguy
CrossRepo test for
c598f32 
- ManageIQ/manageiq#19436
- ManageIQ/manageiq-providers-amazon#569
- ManageIQ/manageiq-gems-pending#451
@Fryguy Fryguy mentioned this pull request Oct 25, 2019
Closed
Fryguy added a commit to Fryguy/manageiq-cross_repo-tests that referenced this pull request Oct 25, 2019
@Fryguy
Reduce the number of gems for AWS SDK usage
0bde277 
- ManageIQ/manageiq#19436
- ManageIQ/manageiq-providers-amazon#569
- ManageIQ/manageiq-gems-pending#451
@miq-bot
Copy link
Member

miq-bot commented Oct 25, 2019

Checked commit Fryguy@0d7fd06 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare self-assigned this Oct 25, 2019
@agrare agrare merged commit f8e7053 into ManageIQ:master Oct 25, 2019
@agrare agrare added this to the Sprint 123 Ending Oct 28, 2019 milestone Oct 25, 2019
NickLaMuro
NickLaMuro reviewed Oct 25, 2019
View reviewed changes
Gemfile
@@ -29,6 +29,8 @@ gem "activerecord-virtual_attributes", "~>1.4.0"
gem "activerecord-session_store", "~>1.1"
gem "acts_as_tree", "~>2.7" # acts_as_tree needs to be required so that it loads before ancestry
gem "ancestry", "~>3.0.7", :require => false
gem "aws-sdk-ec2", "~>1.0", :require => false # For FileDepotS3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fryguy FileDepotS3 shouldn't need ec2 though, right?

Copy link
Member

@NickLaMuro NickLaMuro Oct 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this seems wrong:

manageiq/app/models/file_depot_s3.rb

Lines 65 to 69 in b5c6cd2

def translate_exception(err)
require 'aws-sdk-ec2'
case err
when Aws::EC2::Errors::SignatureDoesNotMatch

Going to investigate...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possible that the code just used Aws::EC2::Errors, but those errors are available elsewhere (perhaps in Aws::S3)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have created a PR to address this here:

#19439

Pretty sure the DynamicErrors should be defining these under the Aws::S3 name space, but wouldn't mind a second set of eyes.

@Fryguy Fryguy deleted the aws_sdk_smaller branch October 25, 2019 19:55
@NickLaMuro NickLaMuro mentioned this pull request Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLaMuro NickLaMuro NickLaMuro left review comments

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fryguy @miq-bot @NickLaMuro @agrare