Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap&U collector tests #19443

Merged
merged 11 commits into from
Nov 5, 2019
Merged

Cap&U collector tests #19443

merged 11 commits into from
Nov 5, 2019

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Oct 29, 2019

Rearrange the Cap & U tests to align the tests with what is tested

metric_spec was testing everything.
Moved tests that test targets.rb into the targets_spec.rb.

@kbrock kbrock marked this pull request as ready for review November 5, 2019 17:54
@miq-bot
Copy link
Member

miq-bot commented Nov 5, 2019

Checked commits kbrock/manageiq@6c38c34~...f511115 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 6 offenses detected

spec/models/metric/capture_spec.rb

spec/models/metric/ci_mixin/capture_spec.rb

spec/models/metric/ci_mixin/rollup_spec.rb

spec/models/metric_spec.rb

@agrare agrare self-assigned this Nov 5, 2019
@kbrock kbrock changed the title [WIP] Cap&U collector tests Cap&U collector tests Nov 5, 2019
@agrare agrare merged commit c53fbbe into ManageIQ:master Nov 5, 2019
@agrare agrare added this to the Sprint 124 Ending Nov 11, 2019 milestone Nov 5, 2019
@kbrock kbrock deleted the cu_collector_tests branch November 5, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants