Add AuthenticationMixin to Vm #19444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits fabiendupont/manageiq@165a212~...76017c4 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
djberg96
approved these changes
Oct 30, 2019
agrare
approved these changes
Oct 31, 2019
agrare
added a commit
that referenced
this pull request
Oct 31, 2019
…n_to_vm Add AuthenticationMixin to Vm
|
Model part of #19501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the
ConversionHostincludes theAuthenticationMixinmixin to perform authentication check. TheConversionHostis associated to a resource: aHostor aVm. TheHostclass also includes theAuthenticationMixinmixin. It seems logical that theVmcould also have authentications and thatConversionHostdelegates authentication related code to its resource.This would also allow other use cases for VM authentication, such as Ansible playbooks. If the VM class includes the
AuthenticationMixinmixin, it allows us to define many purposes authentication. One of them would betransformation(orv2v) for VMs acting as conversion hosts. Another one could beansibleto store the machine credentials along with the managed object.RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1772022