Remove the check for a "current" snapshot #19458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new snapshot and there is at least one snapshot already we are checking to ensure that the first snapshot is "current". This check isn't necessary and can prevent new snapshots from being created through MIQ when it is entirely possible through the underlying provider. Fixes ManageIQ#19396
|
Checked commit agrare@2855ddb with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Nov 5, 2019
There was a problem hiding this comment.
LGTM 👍
This check was added back in 2009 (commit 0043aca596) and seems to follows an existing UI check from 2008 (commit 951f10dd12) but not clear exactly why we were doing this. Either way if this code is required it should exist in the specific provider repo and not at the base model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new snapshot and there is at least one snapshot already
we are checking to ensure that the first snapshot is "current".
This check isn't necessary and can prevent new snapshots from being
created through MIQ when it is entirely possible through the underlying
provider.
Fixes #19396