Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V][IVANCHUK] Fix create_job in JobProxyDispatcher specs #19461

Merged
merged 1 commit into from
Nov 5, 2019
Merged

[V2V][IVANCHUK] Fix create_job in JobProxyDispatcher specs #19461

merged 1 commit into from
Nov 5, 2019

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented Nov 5, 2019

This is a followup to #19277. Unfortunately, there was a core change that broke backwards compatibility.

508683b#diff-96955d17ecd8f0296297c7dc1392d347

So, this is an update for Ivanchuk and earlier that updates the InfraConversionJob.create_job method to use an empty hash as a default value, as well as explicitly specify a process name to the old core method during factory creation.

@miq-bot
Copy link
Member

miq-bot commented Nov 5, 2019

Checked commit https://github.com/djberg96/manageiq/commit/a50a2c226d67120b0ce87f52d7bea5cb57651993 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@simaishi simaishi merged commit f1764d4 into ManageIQ:ivanchuk Nov 5, 2019
@simaishi simaishi added this to the Sprint 124 Ending Nov 11, 2019 milestone Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants