Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding task error status to log management #19480

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Adding task error status to log management #19480

merged 1 commit into from
Nov 11, 2019

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Nov 7, 2019 •
edited
Loading

We should update the task status if log collection fails.

Part of fix for https://bugzilla.redhat.com/show_bug.cgi?id=1767512

@d-m-u d-m-u force-pushed the adding_task_error_status_to_log_management branch from b93a8ec to 9443db4 Compare November 7, 2019 17:57
@miq-bot miq-bot added the wip label Nov 7, 2019
@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2019

Checked commit d-m-u@9443db4 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 7, 2019

@miq-bot add_label bug

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 7, 2019

@miq-bot add_label hammer/yes, ivanchuk/yes

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 7, 2019

@miq-bot assign @jrafanie

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 11, 2019

@miq-bot remove_label wip

@d-m-u d-m-u changed the title [WIP] Adding task error status to log management Adding task error status to log management Nov 11, 2019
@miq-bot miq-bot removed the wip label Nov 11, 2019
@djberg96
Copy link
Contributor

👍

jrafanie
jrafanie approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better than it was. We might have to change something for the local_file here so we can refactor if needed later.

@jrafanie jrafanie merged commit f67305c into ManageIQ:master Nov 11, 2019
@jrafanie jrafanie added this to the Sprint 124 Ending Nov 11, 2019 milestone Nov 11, 2019
@d-m-u d-m-u deleted the adding_task_error_status_to_log_management branch November 11, 2019 19:28
simaishi pushed a commit that referenced this pull request Nov 12, 2019
@jrafanie @simaishi
Merge pull request #19480 from d-m-u/adding_task_error_status_to_log_…
d54c638 
…management

Adding task error status to log management

(cherry picked from commit f67305c)

https://bugzilla.redhat.com/show_bug.cgi?id=1771720
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit d54c638dc90a84448d6d1238dc2a88d69e39aca8
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Mon Nov 11 13:50:16 2019 -0500

    Merge pull request #19480 from d-m-u/adding_task_error_status_to_log_management
    
    Adding task error status to log management
    
    (cherry picked from commit f67305c08e26a7be85a481d24cacb87b7fae625b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1771720

simaishi pushed a commit that referenced this pull request Dec 17, 2019
@jrafanie @simaishi
Merge pull request #19480 from d-m-u/adding_task_error_status_to_log_…
2fa9146 
…management

Adding task error status to log management

(cherry picked from commit f67305c)

https://bugzilla.redhat.com/show_bug.cgi?id=1771722
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 2fa91467400fc92684d6a393e2fbb0274ad59677
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Mon Nov 11 13:50:16 2019 -0500

    Merge pull request #19480 from d-m-u/adding_task_error_status_to_log_management

    Adding task error status to log management

    (cherry picked from commit f67305c08e26a7be85a481d24cacb87b7fae625b)

    https://bugzilla.redhat.com/show_bug.cgi?id=1771722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels
bug hammer/backported ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d-m-u @miq-bot @djberg96 @simaishi @jrafanie