Allow dashboards for different groups to have the same name

[yrudman]

Fixes #18924

This PR should go together with Data Migration PR ManageIQ/manageiq-schema#432, which will copy owner_id to group_id

[Fryguy]

You can also basically remove the group_id variable now, and just use user.current_group_id, since the group_id isn;t needed elsewhere, and you don't need the try because you've checked userid is present.

[yrudman]

👍

[Fryguy]

I expected to see a change to a validator in this code, but there isn't one.

I'm also curious if the data migration and most of this code is even needed if we can get away with group_id || owner_id. I'm sure I'm overlooking something but that's the feeling I get from reading it.

[yrudman]

I expected to see a change to a validator in this code, but there isn't one.

No need to change validation in lib/extentions/ar_miq_sert.rb:

validates_uniqueness_of :name,
                        :scope => [:set_type, :userid, :group_id],
                        :if    => proc { |c| c.class.in_my_region.exists?(:name => c.name) }

the same logic still, but instead of group_id been nil for dashboards assigned to group (and preventing different group to have the same name) it will be <group_id>

.
.

I'm also curious if the data migration and most of this code is even needed if we can get away with group_id || owner_id.

• first thought is: why to use group_id if owner_id already holds that data, BUT acts_as_miq_set is used in 8 models. It would be a massive refactoring to drop group_id column from miq_sets table and alter validation above - very intrusive changes for this small improvement

• without data migration duplicated dashboards for group (the same name) can be created, since old dashboard will have group_id nil and new ones will have <group_id>

[miq-bot]

Checked commits yrudman/manageiq@c691cd3~...6ca85cb with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐