Remove ovirt V3 api calls #19508
Merged
Remove ovirt V3 api calls #19508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit kbrock@dcc114f with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
reviewed
Nov 14, 2019
| @@ -21,7 +21,7 @@ def synchronize_advertised_images_queue | |||
| def advertised_images | |||
| return [] unless ext_management_system.kind_of?(ManageIQ::Providers::Redhat::InfraManager) | |||
|
|
|||
| ext_management_system.ovirt_services(:use_highest_supported_version => true).advertised_images | |||
| ext_management_system.ovirt_services.advertised_images | |||
agrare
reviewed
Nov 14, 2019
| context "does not support api4" do | ||
| let(:supported_api_versions) { ["3"] } | ||
| it "send the method to ovirt services v4" do | ||
| expect_any_instance_of(ManageIQ::Providers::Redhat::InfraManager::OvirtServices::Strategies::V3) |
There was a problem hiding this comment.
I'm surprised this isn't showing as conflicting, I removed this in https://github.com/ManageIQ/manageiq/pull/19499/files#diff-74b0b47136c77206a39c6aad71e63599L23-L32
There was a problem hiding this comment.
Merged cleanly on the command-line
agrare
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to support ManageIQ/manageiq-providers-ovirt#423
https://bugzilla.redhat.com/show_bug.cgi?id=1751098