Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detailed RBAC features for VM and Image reconfigure. #19566

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Add detailed RBAC features for VM and Image reconfigure. #19566

merged 1 commit into from
Dec 4, 2019

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Dec 2, 2019 •
edited
Loading

@martinpovolny martinpovolny mentioned this pull request Dec 2, 2019
Merged
@martinpovolny
Copy link
Member Author

Travis failure is unrelated.

@h-kataria
Copy link
Contributor

@martinpovolny can you please add before/after screenshots

@himdel
Copy link
Contributor

himdel commented Dec 3, 2019

(travis should go green now that #19567 is merged)

@martinpovolny
Copy link
Member Author

Rebased to fix travis.

@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2019

Checked commit martinpovolny@7e67f19 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@h-kataria h-kataria self-assigned this Dec 4, 2019
@h-kataria h-kataria added this to the Sprint 126 Ending Dec 9, 2019 milestone Dec 4, 2019
@h-kataria h-kataria merged commit 2f47eda into ManageIQ:master Dec 4, 2019
simaishi pushed a commit that referenced this pull request Jan 7, 2020
@h-kataria @simaishi
Merge pull request #19566 from martinpovolny/vm_reconv_disk_net2
593a693 
Add detailed RBAC features for VM and Image reconfigure.

(cherry picked from commit 2f47eda)

https://bugzilla.redhat.com/show_bug.cgi?id=1788564
@simaishi
Copy link
Contributor

simaishi commented Jan 7, 2020

Hammer backport details:

$ git log -1
commit 593a693d2baa05fedfdc84a9d76dc5ec17dc900b
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Dec 4 17:35:06 2019 -0500

    Merge pull request #19566 from martinpovolny/vm_reconv_disk_net2

    Add detailed RBAC features for VM and Image reconfigure.

    (cherry picked from commit 2f47edae41cb5e166eb2cbe077a946457a395e4c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1788564

simaishi added a commit that referenced this pull request Jan 7, 2020
@simaishi
Revert "Merge pull request #19566 from martinpovolny/vm_reconv_disk_n…
aa73a61 
…et2"

This reverts commit 593a693.

https://bugzilla.redhat.com/show_bug.cgi?id=1788564
@simaishi
Copy link
Contributor

simaishi commented Jan 7, 2020

Reverted the hammer backport as ui-classic hammer PR isn't ready yet and they need to go together.

commit aa73a61f0784efe3b1afa4a101a4dc867ec7943e
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Tue Jan 7 13:16:09 2020 -0500

    Revert "Merge pull request #19566 from martinpovolny/vm_reconv_disk_net2"

    This reverts commit 593a693d2baa05fedfdc84a9d76dc5ec17dc900b.

    https://bugzilla.redhat.com/show_bug.cgi?id=1788564

@martinpovolny martinpovolny mentioned this pull request Jan 8, 2020
Merged
simaishi pushed a commit that referenced this pull request Jan 9, 2020
@h-kataria @simaishi
Merge pull request #19566 from martinpovolny/vm_reconv_disk_net2
1446d84 
Add detailed RBAC features for VM and Image reconfigure.

(cherry picked from commit 2f47eda)

https://bugzilla.redhat.com/show_bug.cgi?id=1788566
@simaishi
Copy link
Contributor

simaishi commented Jan 9, 2020

Ivanchuk backport details:

$ git log -1
commit 1446d84d7f2875209ae962c22f010b71078209f9
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Dec 4 17:35:06 2019 -0500

    Merge pull request #19566 from martinpovolny/vm_reconv_disk_net2

    Add detailed RBAC features for VM and Image reconfigure.

    (cherry picked from commit 2f47edae41cb5e166eb2cbe077a946457a395e4c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1788566

simaishi pushed a commit that referenced this pull request Jan 17, 2020
@h-kataria @simaishi
Merge pull request #19566 from martinpovolny/vm_reconv_disk_net2
272b50c 
Add detailed RBAC features for VM and Image reconfigure.

(cherry picked from commit 2f47eda)

https://bugzilla.redhat.com/show_bug.cgi?id=1788564
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 272b50c21c2508dad309fd9d1a0110e0a3b4997c
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Dec 4 17:35:06 2019 -0500

    Merge pull request #19566 from martinpovolny/vm_reconv_disk_net2

    Add detailed RBAC features for VM and Image reconfigure.

    (cherry picked from commit 2f47edae41cb5e166eb2cbe077a946457a395e4c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1788564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria approved these changes

Assignees

@h-kataria h-kataria

Labels
changelog/yes enhancement hammer/backported ivanchuk/backported providers/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@martinpovolny @h-kataria @himdel @miq-bot @simaishi @Fryguy