Add queue_name to queued method options for CloudVolume model #19570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
changed the title
|
Checked commits https://github.com/djberg96/manageiq/compare/1d76ae7169706dbb45a4dcd954204a054085b6c6~...335c620b103815a94c39224b43e3e8dfa09a8a1b with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Dec 3, 2019
This was referenced Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a queue_name to the queue options for the
CloudVolume.create_volume_queue,CloudVolume#update_volume_queueandCloudVolume#delete_volume_queuemethods.I've also added some specs (these methods were previously uncovered), refactored the existing specs (mostly so I could re-use the factories), and added some comments on those methods.
Part of #19543