Add external_distributed_virtual_switch #19576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Dec 4, 2019
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
This is required for rhv provider to support the networks managed by external providers. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Required for: ManageIQ/manageiq-providers-ovirt#444
borod108
force-pushed
the
remod_network_external
branch
from
e7bf3b1
to
8478e67
Compare
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Dec 4, 2019
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
|
Checked commit borod108@8478e67 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/manageiq/providers/inventory/persister/builder/infra_manager.rb
|
|
@agrare please take a look. |
|
@borod108 I think the external switch can just be a subclass in the ovirt provider, no need for a core change |
|
Also, it feels like |
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Dec 4, 2019
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Dec 9, 2019
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Dec 11, 2019
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Dec 17, 2019
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Dec 17, 2019
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Dec 17, 2019
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Dec 17, 2019
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
|
Since ManageIQ/manageiq-providers-ovirt#450 is merged with this class in the provider I'm going to go ahead and close this |
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Jan 8, 2020
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Jan 10, 2020
Remodel the networking to add the vnic profiles related to networks that are managed by external providers to the provisioning network dialog. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787 Depends on: ManageIQ/manageiq#19576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for rhv provider to support the networks managed by
external providers.
Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1767787
Required for: ManageIQ/manageiq-providers-ovirt#444