Add queue name to ManageIQ::Providers::CloudManager::Vm queue methods #19625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Dec 10, 2019
agrare
reviewed
Dec 11, 2019
|
@agrare Looks like cross repo tests are green. |
|
@agrare ok, done. |
agrare
approved these changes
Dec 11, 2019
|
Checked commits https://github.com/djberg96/manageiq/compare/522aebeb3ecb93f1f0ea03fea29d483dd8d8d9c2~...ba90b6e3ae47ba0e02c3911d2a11e2b02c83608a with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a queue_name to all of the
ManageIQ::Providers::CloudManager::Vmqueued methods.I've also added some specs (these methods were previously uncovered) and added some comments on those methods.
Part of #19543
Cross repo tests at ManageIQ/manageiq-cross_repo-tests#36