Reduce number of cockpit selinux changes #19631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't need to live here, it isn't tested, doesn't use our models and moving it removes a few AVC denials when running cockpit-ws https://bugzilla.redhat.com/show_bug.cgi?id=1779988
…t-ws This was causing the ruby authentication process to look for our Gemfile and Gemfile.lock which caused a bunch of SELinux denials https://bugzilla.redhat.com/show_bug.cgi?id=1779988
Since we are creating the files, they will have the same context as our process (httpd_sys_content_t), we want these files to have the context of the parent directory (etc_t) so that they can be read by cockpit-ws without SELinux denials https://bugzilla.redhat.com/show_bug.cgi?id=1779988
|
Checked commits carbonin/manageiq@53207cb~...cbeb464 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/miq_cockpit_ws_worker/runner.rb
|
simaishi
pushed a commit
that referenced
this pull request
Dec 17, 2019
…nux_changes Reduce number of cockpit selinux changes (cherry picked from commit 771f620) https://bugzilla.redhat.com/show_bug.cgi?id=1784555
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the cockpit proxy work alongside cockpit used to manage the appliance we need a more targeted selinux policy.
To make this easier we can make some changes here to give
cockpit-wsfewer permissions to the files in our source tree.https://bugzilla.redhat.com/show_bug.cgi?id=1779988