Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back missing requires for rubyzip #19636

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Add back missing requires for rubyzip #19636

merged 1 commit into from
Dec 12, 2019

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Dec 12, 2019 •
edited
Loading

Yes okay I broke it in #19629, we needed to keep the requires.

@miq-bot assign @jrafanie

the related pr is ManageIQ/manageiq-automation_engine#400

😭 the cross repo tests didn't ...

@d-m-u d-m-u mentioned this pull request Dec 12, 2019
Merged
@d-m-u d-m-u force-pushed the fixing_requires_i_just_broke branch from b073591 to d4d858e Compare December 12, 2019 17:25
@miq-bot
Copy link
Member

miq-bot commented Dec 12, 2019

Checked commit d-m-u@d4d858e with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@simaishi simaishi changed the title We need these requires, oops Add back missing requires for rubyzip Dec 12, 2019
@jrafanie jrafanie merged commit 43306a5 into ManageIQ:master Dec 12, 2019
@jrafanie jrafanie added this to the Sprint 127 Ending Jan 6, 2020 milestone Dec 12, 2019
@d-m-u d-m-u deleted the fixing_requires_i_just_broke branch December 12, 2019 18:06
@jrafanie jrafanie mentioned this pull request Dec 13, 2019
Merged
simaishi pushed a commit that referenced this pull request Dec 13, 2019
@jrafanie @simaishi
Merge pull request #19636 from d-m-u/fixing_requires_i_just_broke
642cc87 
Add back missing requires for rubyzip

(cherry picked from commit 43306a5)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1783403
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 642cc878f7351c4602d6311812ade21a93a94a25 (HEAD -> hammer)
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Thu Dec 12 13:05:57 2019 -0500

    Merge pull request #19636 from d-m-u/fixing_requires_i_just_broke

    Add back missing requires for rubyzip

    (cherry picked from commit 43306a5756440a6cfa1776b462081be5c6dd1f74)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1783403

simaishi pushed a commit that referenced this pull request Dec 16, 2019
@jrafanie @simaishi
Merge pull request #19636 from d-m-u/fixing_requires_i_just_broke
c884353 
Add back missing requires for rubyzip

(cherry picked from commit 43306a5)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1783401
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit c8843536502e0f0564bb7ab9a03c49b06669815f
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Thu Dec 12 13:05:57 2019 -0500

    Merge pull request #19636 from d-m-u/fixing_requires_i_just_broke

    Add back missing requires for rubyzip

    (cherry picked from commit 43306a5756440a6cfa1776b462081be5c6dd1f74)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1783401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrafanie jrafanie

Labels
bug core hammer/backported ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-m-u @miq-bot @simaishi @jrafanie