Add queue_name to ems operations for ManageIQ::Providers::CloudManager::AuthKeyPair #19651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits https://github.com/djberg96/manageiq/compare/3f7e24e1b8a83444bc7ee4d4e48a42113db9aeea~...cd7ec8194e177195b3763db2a5450c581c00601e with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a queue_name to the queue options for the
ManageIQ::Providers::CloudManager::AuthKeyPairqueued methods that are ems operations.I've also added some specs since these methods were previously uncovered, as well as some comments.
Part of #19543
Cross-repo tests at ManageIQ/manageiq-cross_repo-tests#40