Remove VMwareWebService from the main Gemfile #19704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the VMwareWebService gem from the core Gemfile now that all core references to VMwareWebService and MiqVim have been moved to the VMware repo.
Fryguy
approved these changes
Jan 9, 2020
|
Do we need any cross_repo testing? |
|
@Fryguy Yeah I'm putting that together now |
|
Checked commit agrare@b0f4d86 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@Fryguy ManageIQ/manageiq-cross_repo-tests#53 is green (both passed, not sure why it is saying one is still in progress) |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the VMwareWebService gem from the core Gemfile now that all
core references to VMwareWebService and MiqVim have been moved to the
VMware repo.
Cross Repo Tests: ManageIQ/manageiq-cross_repo-tests#53
Fixes #18428