Differentiate deployment names by server #19712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for when we have workers belonging to different "servers" running in the same namespace. This commit also attempts to deal with the possibility of multiple service based worker deployments. We need the service name to remain static so that we can configure the httpd pod correctly. To achieve this we strip the server identifier off the front of the worker deployment name for service workers to get the service name. This commit deals with multiple service worker deployments by changing the label selector on the service from the deployment name to a more generic label for the service name which all deployments for that service will have. This allows the single service to front all of the separate service deployments. In practice, I would expect a single "server" to run the UI role so the service to deployment would still be 1-to-1
|
Checked commit carbonin@1f5e6b0 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Fryguy
reviewed
Jan 15, 2020
|
|
||
| def deployment_name_for(name) | ||
| "#{compressed_server_id}-#{name}" | ||
| end |
There was a problem hiding this comment.
Should this just be part of the ContainerCommon as a class method? Then the specs can share it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for when we have workers belonging to different
"servers" running in the same namespace.
This commit also attempts to deal with the possibility of multiple
service based worker deployments. We need the service name to remain
static so that we can configure the httpd pod correctly. To achieve
this we strip the server identifier off the front of the worker
deployment name for service workers to get the service name.
This commit deals with multiple service worker deployments by
changing the label selector on the service from the deployment
name to a more generic label for the service name which all
deployments for that service will have.
This allows the single service to front all of the separate service
deployments.
In practice, I would expect a single "server" to run the UI role
so the service to deployment would still be 1-to-1
ManageIQ/manageiq-pods#353