Use a single query to get count of active VMs and Hosts #19835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of looping through all ExtManagementSystems and adding up the counts of vms and hosts manually we can get this count in one shot by querying for active VMs and Hosts.
agrare
force-pushed
the
improve_audit_managed_resources_performance
branch
from
17b393e
to
2f83c8f
Compare
agrare
commented
Feb 14, 2020
| @@ -143,6 +143,9 @@ class Host < ApplicationRecord | |||
| virtual_total :v_total_vms, :vms | |||
| virtual_total :v_total_miq_templates, :miq_templates | |||
|
|
|||
| scope :active, -> { where.not(:ems_id => nil) } | |||
| scope :archived, -> { where(:ems_id => nil) } | |||
There was a problem hiding this comment.
These are handy scopes to have, only the active scope here is used but both are generally helpful
|
Checked commit agrare@2f83c8f with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
|
/cc @jaredm-ibm |
|
LGTM - will merge when tests are green |
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
…_performance Use a single query to get count of active VMs and Hosts (cherry picked from commit cee35bf) https://bugzilla.redhat.com/show_bug.cgi?id=1805915
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looping through all ExtManagementSystems and adding up the counts of vms and hosts manually we can get this count in one shot by querying for active VMs and Hosts.
Follow-up for #19830