Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Productize pods without product name #19847

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Feb 18, 2020

This PR allows for changing the app name in a pods objects based on an environment variable rather than using the application name from our source.

Requires ManageIQ/manageiq-pods#369

@miq-bot
Copy link
Member

miq-bot commented Feb 18, 2020

Checked commits carbonin/manageiq@46bf06f~...f2cba89 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@carbonin carbonin assigned bdunne and unassigned Fryguy Feb 19, 2020
@bdunne bdunne merged commit c960ff0 into ManageIQ:master Feb 19, 2020
@bdunne bdunne added this to the Sprint 131 Ending Mar 2, 2020 milestone Feb 19, 2020
@carbonin carbonin deleted the productize_pods_better branch February 19, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants