-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded ansible provider should allow creation in maintenance zone #19947
Conversation
@miq-bot add_label bug |
|
||
context "ensure_managers callback" do | ||
before do | ||
EvmSpecHelper.local_miq_server(:is_master => true, :zone => Zone.seed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think :zone => Zone.seed
is what you're looking for here. I think you want to add
MiqRegion.seed
Zone.seed
here before the assign_embedded_ansible_role(miq_server)
Checked commits https://github.com/djberg96/manageiq/compare/0e66f9f8490cb957ff8c487a8e8563942cf4b43b~...092e45510da4f602531182c0e56b2b8d0d74f613 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
Currently you cannot create an embedded Ansible provider in the maintenance zone. Instead, this should be legal, though with the automation manager disabled.
You can see the current behavior here:
This PR alters the
ensure_managers
method to allow it, setting theenabled
attribute as appropriate.Based on ManageIQ/manageiq-providers-ansible_tower#211