Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix storage profile ems foreign key #20038

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Apr 1, 2020

got the error that there is no ext_management_system_id
which is valid.

All other belongs_to :ext_management_system declarations also include
the foreign key

This caused an error when assigning an ems to a storage profile

got the error that there is no ext_management_system_id
which is valid.

All other belongs_to :ext_management_system declarations also include
the foreign key

This caused an error when assigning an ems to a storage profile
@miq-bot
Copy link
Member

miq-bot commented Apr 1, 2020

Checked commit kbrock@4cdcf40 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 1 offense detected

app/models/storage_profile.rb

@agrare agrare self-assigned this Apr 1, 2020
@agrare agrare merged commit a0fe4ca into ManageIQ:master Apr 1, 2020
@kbrock kbrock deleted the storage_profile_ems branch April 2, 2020 06:45
@jrafanie
Copy link
Member

jrafanie commented Apr 2, 2020

@miq-bot add_label jansa/yes?

@chessbyte chessbyte mentioned this pull request Apr 2, 2020
38 tasks
simaishi pushed a commit that referenced this pull request Apr 3, 2020
fix storage profile ems foreign key

(cherry picked from commit a0fe4ca)
@simaishi
Copy link
Contributor

simaishi commented Apr 3, 2020

Jansa backport details:

$ git log -1
commit 58a2fbc2f44fc752f5d7efcf8132ae93621254b5
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Apr 1 18:43:21 2020 -0400

    Merge pull request #20038 from kbrock/storage_profile_ems

    fix storage profile ems foreign key

    (cherry picked from commit a0fe4caeab04e1f3d32ad1f5da82e84a50997584)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants