Add an owner reference to the orchestrator pod for all created objects #20070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow anything we create to be automatically removed when the orchestrator pod is removed for any reason. If the pod is cleanly scaled down we will continue to tell the workers to exit cleanly, but if the orchestrator is abruptly removed this will ensure everything is cleaned up properly. Fixes ManageIQ/manageiq-pods#428
|
Checked commit carbonin@539a2cb with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
simaishi
pushed a commit
that referenced
this pull request
Apr 16, 2020
Add an owner reference to the orchestrator pod for all created objects (cherry picked from commit 1f07002)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow anything we create to be automatically removed when
the orchestrator pod is removed for any reason. If the pod is cleanly
scaled down we will continue to tell the workers to exit cleanly, but
if the orchestrator is abruptly removed this will ensure everything
is cleaned up properly.
Requires ManageIQ/manageiq-pods#440
Fixes ManageIQ/manageiq-pods#428