Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CONTAINER_IMAGE_TAG for worker deployment tag #20094

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Use CONTAINER_IMAGE_TAG for worker deployment tag #20094

merged 1 commit into from
Apr 23, 2020

Conversation

carbonin
Copy link
Member

This will start the worker containers with the same tag as the orchestrator

ManageIQ/manageiq-pods#464

@carbonin carbonin requested a review from jrafanie as a code owner April 23, 2020 15:21
@carbonin carbonin mentioned this pull request Apr 23, 2020
Merged
@carbonin carbonin mentioned this pull request Apr 23, 2020
Closed
@miq-bot
Copy link
Member

miq-bot commented Apr 23, 2020

Checked commit carbonin@bdf7462 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy merged commit e3ce541 into ManageIQ:master Apr 23, 2020
simaishi pushed a commit that referenced this pull request Apr 27, 2020
@Fryguy @simaishi
Merge pull request #20094 from carbonin/send_image_tag_to_workers
3c2e69f 
Use CONTAINER_IMAGE_TAG for worker deployment tag

(cherry picked from commit e3ce541)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 3c2e69ff3ef443f5cdd4c3bb45967072c524126a
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Apr 23 16:07:16 2020 -0400

    Merge pull request #20094 from carbonin/send_image_tag_to_workers

    Use CONTAINER_IMAGE_TAG for worker deployment tag

    (cherry picked from commit e3ce541ef7859a42401914acb904e63f84c791b2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie Awaiting requested review from jrafanie jrafanie is a code owner

Assignees

@Fryguy Fryguy

Labels
bug core jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carbonin @miq-bot @simaishi @Fryguy